Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 115843: Add Linux packaging tools to the build output and the buildbot archive. (Closed)

Created:
11 years, 7 months ago by Michael Moss
Modified:
9 years, 7 months ago
Reviewers:
jon, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add Linux packaging tools to the build output and the buildbot archive. This makes the buildbot archive hermetic for package building, rather than pulling files from the package builder's source tree (e.g. BRANDING) and system (e.g. lib32 stuff). Note, this currently only applies to official builds since that's all we package. This depends on: http://codereview.chromium.org/115842 http://codereview.chromium.org/113966

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix merge conflicts #

Patch Set 3 : Rearrange gyp conditions and add official FILES #

Total comments: 1

Patch Set 4 : merge gyp conditions blocks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -384 lines) Patch
M chrome/chrome.gyp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/installer/installer.gyp View 1 2 3 1 chunk +483 lines, -384 lines 0 comments Download
A chrome/tools/build/linux/FILES.official View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Moss
11 years, 7 months ago (2009-05-28 00:19:02 UTC) #1
sgk
lgtm, modulo one stylistic change http://codereview.chromium.org/115843/diff/1/3 File chrome/installer/installer.gyp (right): http://codereview.chromium.org/115843/diff/1/3#newcode82 Line 82: ['OS=="linux"', { Move ...
11 years, 7 months ago (2009-05-28 04:15:31 UTC) #2
Michael Moss
I actually had to rearrange a lot more of installer.gyp after merging with recent changes. ...
11 years, 7 months ago (2009-05-28 19:45:40 UTC) #3
sgk
cursory glance, most things look good, but i think you may be overwriting the first ...
11 years, 7 months ago (2009-05-28 20:11:00 UTC) #4
Michael Moss
OK, I merged the conditions blocks. I had tried to do that before and got ...
11 years, 7 months ago (2009-05-28 20:39:02 UTC) #5
sgk
11 years, 7 months ago (2009-05-28 20:51:02 UTC) #6
yeah, looks like it.  lgtm

Powered by Google App Engine
This is Rietveld 408576698