Add default version information and ability to output to stdout.

Add default version information and ability to output to stdout.

This is useful for getting general build version information, such as needed
for Linux packaging.

[sgk, 2009-05-28 04:04:47]

http://codereview.chromium.org/115842/diff/1/2
File chrome/tools/build/version.py (right):

http://codereview.chromium.org/115842/diff/1/2#newcode1
Line 1: #!/usr/bin/env python
Good catch; thanks.

http://codereview.chromium.org/115842/diff/1/2#newcode193
Line 193: if len(args):
More efficient+compact, just:

if args:

http://codereview.chromium.org/115842/diff/1/2#newcode196
Line 196: msg = 'Incorrect number of arguments: %r' % args
The way you've changed the code in the try: block above, this error message
isn't going to make any sense.  "args" will just contain the leftover arguments,
and as a naive user I'd expect to see all the arguments.  Just get rid of the
try:-except: and raise Usage() directly in the if test:

  if args:
    msg = 'Unexpected arguments: %r' 
% args
    raise Usage(msg)

http://codereview.chromium.org/115842/diff/1/2#newcode206
Line 206: if not in_file is None:
Just:

if in_file:

http://codereview.chromium.org/115842/diff/1/2#newcode217
Line 217: values['LASTCHANGE'], values['OFFICIAL_BUILD'])
Instead of positional substition, more readable to use the %(key)s substitution:

contents = """MAJOR=%(MAJOR)s
MINOR=%(MINOR)s
BUILD=%(BUILD)s
PATCH=%(PATCH)S
LASTCHANGE=%(LASTCHANGE)s
OFFICIAL_BUILD=%(OFFICIAL_BUILD)s
""" % values

http://codereview.chromium.org/115842/diff/1/2#newcode220
Line 220: if not out_file is None:
More readable:  either invert the condition and swap the blocks:

if out_file is None:

Or leave the blocks in the same order and:

if out_file:

[Michael Moss, 2009-05-28 16:46:26]

http://codereview.chromium.org/115842/diff/1/2
File chrome/tools/build/version.py (right):

http://codereview.chromium.org/115842/diff/1/2#newcode217
Line 217: values['LASTCHANGE'], values['OFFICIAL_BUILD'])
Cool, I wasn't aware of that syntax.

[sgk, 2009-05-28 19:38:45]

lgtm