Issue 113966: Preserve symlinks with the gyp "copies" command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113966: Preserve symlinks with the gyp "copies" command. (Closed)

Created:
11 years, 6 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Preserve symlinks with the gyp "copies" command. superceded by sgk's upstream changes

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	pylib/gyp/generator/scons.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM, but... cp -d is non-portable. I guess this is OK since we're assuming GNU ...

11 years, 6 months ago (2009-05-28 21:16:11 UTC) #3

Michael Moss

> Linux, which is the only place we use scons now. If there's a way ...

11 years, 6 months ago (2009-05-28 21:17:51 UTC) #4

Michael Moss

11 years, 6 months ago (2009-05-28 21:18:12 UTC) #5

On 2009/05/28 21:17:51, mmoss wrote:
> > Linux, which is the only place we use scons now.  If there's a way to do
this
> > without having to rely on cp extensions, that'd probably be better.
> 
> I don't know. Does scons have a portable 'cp' alternative?

Once which handles symlinks?

Expand Messages | Collapse Messages