Issue 115123: Return immediately from GetLogLines if logging to memory isn't enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115123: Return immediately from GetLogLines if logging to memory isn't enabled. (Closed)

Created:
11 years, 7 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Return immediately from GetLogLines if logging to memory isn't enabled. Committed: http://code.google.com/p/v8/source/detail?r=1901

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	src/log.cc	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	test/cctest/test-log.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/115123/diff/1/2 File src/log.cc (right): http://codereview.chromium.org/115123/diff/1/2#newcode426 Line 426: if (Write != WriteToMemory) return 0; Maybe ...

11 years, 7 months ago (2009-05-08 09:59:33 UTC) #2

Mikhail Naganov

11 years, 7 months ago (2009-05-08 10:06:15 UTC) #3

Thanks for finding a minute of your holiday time on a review!

http://codereview.chromium.org/115123/diff/1/2
File src/log.cc (right):

http://codereview.chromium.org/115123/diff/1/2#newcode426
Line 426: if (Write != WriteToMemory) return 0;
On 2009/05/08 09:59:33, Søren Gjesse wrote:
> Maybe we should consider having an enum to indicate to where log output is
going
> instead of checking the write function.

And end up have two variables for specifying mode (Write and the new enum)? No.
I think the current semantics is fine.

Expand Messages | Collapse Messages