Return immediately from GetLogLines if logging to memory isn't enabled.

test/cctest/test-log.cc

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 //
 // Tests of logging functions from log.h
 
 #ifdef ENABLE_LOGGING_AND_PROFILING
 
 #include "v8.h"
 
 #include "log.h"
 
 #include "cctest.h"
 
 using v8::internal::Logger;
 
 static void SetUp() {
   // Log to memory buffer.
   v8::internal::FLAG_logfile = "*";
   v8::internal::FLAG_log = true;
   Logger::Setup();
 }
 
 static void TearDown() {
   Logger::TearDown();
 }
 
+
 TEST(EmptyLog) {
   SetUp();
   CHECK_EQ(0, Logger::GetLogLines(0, NULL, 0));
   CHECK_EQ(0, Logger::GetLogLines(100, NULL, 0));
   CHECK_EQ(0, Logger::GetLogLines(0, NULL, 100));
   CHECK_EQ(0, Logger::GetLogLines(100, NULL, 100));
   TearDown();
 }
 
 
@@ skipping 56 matching lines @@
   CHECK_EQ(0, Logger::GetLogLines(all_lines_len, NULL, 100));
   CHECK_EQ(0, Logger::GetLogLines(all_lines_len + 1, NULL, 1));
   CHECK_EQ(0, Logger::GetLogLines(all_lines_len + 1, NULL, 100));
   CHECK_EQ(0, Logger::GetLogLines(all_lines_len + 100, NULL, 1));
   CHECK_EQ(0, Logger::GetLogLines(all_lines_len + 100, NULL, 100));
   CHECK_EQ(0, Logger::GetLogLines(10 * 1024 * 1024, NULL, 1));
   CHECK_EQ(0, Logger::GetLogLines(10 * 1024 * 1024, NULL, 100));
   TearDown();
 }
 
+
+TEST(MemoryLoggingTurnedOff) {
+  // Log to stdout
+  v8::internal::FLAG_logfile = "-";
+  v8::internal::FLAG_log = true;
+  Logger::Setup();
+  CHECK_EQ(0, Logger::GetLogLines(0, NULL, 0));
+  CHECK_EQ(0, Logger::GetLogLines(100, NULL, 0));
+  CHECK_EQ(0, Logger::GetLogLines(0, NULL, 100));
+  CHECK_EQ(0, Logger::GetLogLines(100, NULL, 100));
+  Logger::TearDown();
+}
+
+
 #endif  // ENABLE_LOGGING_AND_PROFILING