Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: src/log.cc

Issue 115123: Return immediately from GetLogLines if logging to memory isn't enabled. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index b4e20540a14bc4ba631efc7fcfc2114f59d05a75..5297a302d80d7cdfde3fd8c224c6625de6f577c6 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -423,6 +423,7 @@ void Log::Close() {
int Log::GetLogLines(int from_pos, char* dest_buf, int max_size) {
+ if (Write != WriteToMemory) return 0;
Søren Thygesen Gjesse 2009/05/08 09:59:33 Maybe we should consider having an enum to indicat
Mikhail Naganov 2009/05/08 10:06:15 And end up have two variables for specifying mode
ASSERT(output_.buffer != NULL);
ASSERT(output_buffer_write_pos_ >= output_.buffer);
ASSERT(from_pos >= 0);
« no previous file with comments | « no previous file | test/cctest/test-log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698