chromeos/dbus/shill_network_client.cc - Issue 11367048: This is the first pass at making GetIPConfigs asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_network_client.cc

Issue 11367048: This is the first pass at making GetIPConfigs asynchronous. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_network_client.cc

diff --git a/chromeos/dbus/shill_network_client.cc b/chromeos/dbus/shill_network_client.cc

index faa399b03bdd02cd30267e2a7de1dd892d31d519..290f5bd7630157e11de368deab5b14456f0260ff 100644

--- a/chromeos/dbus/shill_network_client.cc

+++ b/chromeos/dbus/shill_network_client.cc

@@ -115,8 +115,8 @@ class ShillNetworkClientStubImpl : public ShillNetworkClient {

private:

void PassEmptyDictionaryValue(const DictionaryValueCallback& callback) const {

- base::DictionaryValue dictionary;

- callback.Run(DBUS_METHOD_CALL_SUCCESS, dictionary);

+ scoped_ptr<base::DictionaryValue> empty(new base::DictionaryValue);

+ callback.Run(DBUS_METHOD_CALL_SUCCESS, empty.Pass());

}

// Note: This should remain the last member so it'll be destroyed and