chromeos/dbus/shill_manager_client.cc - Issue 11367048: This is the first pass at making GetIPConfigs asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_manager_client.cc

Issue 11367048: This is the first pass at making GetIPConfigs asynchronous. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_manager_client.cc

diff --git a/chromeos/dbus/shill_manager_client.cc b/chromeos/dbus/shill_manager_client.cc

index caffa301c7f37cc542d5b165084e2f354873575a..ee7a54f456371cc9a2e4406a9204baa3f14378fd 100644

--- a/chromeos/dbus/shill_manager_client.cc

+++ b/chromeos/dbus/shill_manager_client.cc

@@ -362,7 +362,9 @@ class ShillManagerClientStubImpl : public ShillManagerClient,

}

void PassStubProperties(const DictionaryValueCallback& callback) const {

- callback.Run(DBUS_METHOD_CALL_SUCCESS, stub_properties_);

+ scoped_ptr<base::DictionaryValue> properties_copy(

+ stub_properties_.DeepCopy());

+ callback.Run(DBUS_METHOD_CALL_SUCCESS, properties_copy.Pass());

}

void NotifyObserversPropertyChanged(const std::string& property) {