chromeos/dbus/shill_profile_client.cc - Issue 11367048: This is the first pass at making GetIPConfigs asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_profile_client.cc

Issue 11367048: This is the first pass at making GetIPConfigs asynchronous. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_profile_client.cc

diff --git a/chromeos/dbus/shill_profile_client.cc b/chromeos/dbus/shill_profile_client.cc

index 6b2544c4b7005a8e5c41ee598e78fe1b1c59777d..3311a8dcb33d9e5e3146e47aaf6d0991a5196e4a 100644

--- a/chromeos/dbus/shill_profile_client.cc

+++ b/chromeos/dbus/shill_profile_client.cc

@@ -168,8 +168,8 @@ class ShillProfileClientStubImpl : public ShillProfileClient {

private:

void PassEmptyDictionaryValue(

const DictionaryValueCallbackWithoutStatus& callback) const {

- base::DictionaryValue dictionary;

- callback.Run(dictionary);

+ scoped_ptr<base::DictionaryValue> empty(new base::DictionaryValue);

+ callback.Run(empty.Pass());

}

// Note: This should remain the last member so it'll be destroyed and