Android WebView save/restoreState and copyBackForwardList

Android WebView save/restoreState and copyBackForwardList

BUG=

Android/Java only change to disable tests. Compiles.
NOTRY=true

[boliu, 2012-11-18 22:41:46]

See my comments in bug. Feel free to cq (already has NOTRY=true) when you
l-g-t-m this.

[boliu, 2012-11-19 00:27:53]

On 2012/11/18 22:41:46, boliu wrote:
> See my comments in bug. Feel free to cq (already has NOTRY=true) when you
> l-g-t-m this.

Oops, wrong issue. Should be this one: http://codereview.chromium.org/11316072/

[mkosiba (inactive), 2012-11-20 17:38:56]

created these before I noticed the issue is closed, useful?

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
(right):

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java:278:
* Note that exceptions are threaded as failure.
threaded or treated?

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
(right):

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:226:
public void testGetHistoryItemList() throws Throwable {
this doesn't look like it does anything

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
File
android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java
(right):

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java:17:
private static class TestVars {
why do you need this? IIRC all of these can be accessed via AwTestContainerView

https://chromiumcodereview.appspot.com/11348113/diff/1/android_webview/javate...
android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java:121:
public void testHistoryItemListNoNavigation() throws Throwable {
maybe we should have a separate test case for t

[boliu, 2012-11-20 18:58:16]

This issue is closed. Real patches for review:

https://codereview.chromium.org/11420056/
https://codereview.chromium.org/11280064/

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
(right):

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java:278:
* Note that exceptions are threaded as failure.
On 2012/11/20 17:38:56, Martin Kosiba wrote:
> threaded or treated?

treated

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
(right):

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:226:
public void testGetHistoryItemList() throws Throwable {
On 2012/11/20 17:38:56, Martin Kosiba wrote:
> this doesn't look like it does anything

Removed in actual patches.

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java
(right):

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java:17:
private static class TestVars {
On 2012/11/20 17:38:56, Martin Kosiba wrote:
> why do you need this? IIRC all of these can be accessed via
AwTestContainerView

For convenience only. As you can see from the constructor, yes, everything is
accessible from the view.

https://codereview.chromium.org/11348113/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java:121:
public void testHistoryItemListNoNavigation() throws Throwable {
On 2012/11/20 17:38:56, Martin Kosiba wrote:
> maybe we should have a separate test case for t

not applicable anymore, I found a whole other file testing navigation history.