Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 11316072: Disable flaky AndroidWebView Find tests (Closed)

Created:
8 years, 1 month ago by boliu
Modified:
8 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Disable flaky AndroidWebView Find tests Flakiness likely due to deadlock. BUG=158112 Android/Java only change to disable tests. Compiles. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewMixedFindApisTest.java View 2 chunks +5 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
boliu
See my comments in bug. Feel free to cq (already has NOTRY=true) when you l-g-t-m ...
8 years, 1 month ago (2012-11-19 00:28:34 UTC) #1
joth
lgtm
8 years, 1 month ago (2012-11-21 02:22:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/11316072/1
8 years, 1 month ago (2012-11-21 02:22:22 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-21 02:22:33 UTC) #4
Change committed as 168953

Powered by Google App Engine
This is Rietveld 408576698