Add a remove method to the hash map

Add a remove method to the hash map.

Extended the hash map test to also use a heavy collision hash function to exercise the remove code.

Committed: http://code.google.com/p/v8/source/detail?r=1956

[iposva, 2009-05-14 16:53:38]

http://codereview.chromium.org/113397/diff/10/13
File src/hashmap.cc (right):

http://codereview.chromium.org/113397/diff/10/13#newcode111
Line 111: }
Comments please. This is non-trivial code...

[Dean McNamee, 2009-05-14 18:48:38]

Typo in your commit description...

[Christian Plesner Hansen, 2009-05-15 06:51:29]

Lgtm w/ comments.

http://codereview.chromium.org/113397/diff/10/13
File src/hashmap.cc (right):

http://codereview.chromium.org/113397/diff/10/13#newcode88
Line 88: Entry *p = Probe(key, hash);
More descriptive variable names might make this easier to understand.

[Søren Thygesen Gjesse, 2009-05-15 07:08:44]

http://codereview.chromium.org/113397/diff/10/13
File src/hashmap.cc (right):

http://codereview.chromium.org/113397/diff/10/13#newcode88
Line 88: Entry *p = Probe(key, hash);
On 2009/05/15 06:51:29, Christian Plesner Hansen wrote:
> More descriptive variable names might make this easier to understand.

With the comments I think the names are fine.

http://codereview.chromium.org/113397/diff/10/13#newcode111
Line 111: }
On 2009/05/14 16:53:38, iposva wrote:
> Comments please. This is non-trivial code...

Comments added.

[Dean McNamee, 2009-05-15 07:24:00]

http://codereview.chromium.org/113397/diff/17/20
File src/hashmap.cc (right):

http://codereview.chromium.org/113397/diff/17/20#newcode96
Line 96: // entry that will cause search for an entry to stop to soon. If all
the
too soon

http://codereview.chromium.org/113397/diff/17/20#newcode98
Line 98: // initial position inside this interval clearing the entry to remove
will not
interval,

http://codereview.chromium.org/113397/diff/17/20#newcode101
Line 101: // remove and the position looked at this entry can be moved to the
place of
looked at,

http://codereview.chromium.org/113397/diff/17/20#newcode103
Line 103: // remove will be its previous position.
runon :)

http://codereview.chromium.org/113397/diff/17/20#newcode107
Line 107: // eventually the removed entyr will have an empty entry after it.
entry