X64: General fixes - added inline definitions and changed tome places to intptr_t.

X64: General fixes - added inline definitions and changed some places to intptr_t.

[Lasse Reichstein, 2009-05-11 15:33:00]

Please review small fixes.

[Dean McNamee, 2009-05-12 08:22:40]

http://codereview.chromium.org/113199/diff/1/2
File src/disassembler.cc (right):

http://codereview.chromium.org/113199/diff/1/2#newcode46
Line 46: PrintF("%"V8PRIp"  %4"V8PRId"  %02x\n", pc, pc - begin, *pc);
should we put space around these?  It looks weird, but I guess it will look
weird no matter what.

http://codereview.chromium.org/113199/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/113199/diff/1/4#newcode6729
Line 6729: static_cast<uint32_t>(reinterpret_cast<uintptr_t>(map));
comment about truncation?

http://codereview.chromium.org/113199/diff/1/5
File src/runtime.cc (right):

http://codereview.chromium.org/113199/diff/1/5#newcode4448
Line 4448: #ifdef V8_HOST_ARCH_64_BIT
I have just been doing #if, we should be consistent and go with one.  I thin #if
is easier.

http://codereview.chromium.org/113199/diff/1/5#newcode6040
Line 6040: #ifdef V8_HOST_ARCH_64_BIT
#if

[Erik Corry, 2009-05-12 09:24:50]

LGTM

http://codereview.chromium.org/113199/diff/1/2
File src/disassembler.cc (right):

http://codereview.chromium.org/113199/diff/1/2#newcode46
Line 46: PrintF("%"V8PRIp"  %4"V8PRId"  %02x\n", pc, pc - begin, *pc);
On 2009/05/12 08:22:40, Dean McNamee wrote:
> should we put space around these?  It looks weird, but I guess it will look
> weird no matter what.

I think the names are way too cryptic considering they are not used all that
many places.  The name V8PRId does not say "use this where you want to print a
ptrdiff_t" to me.  I would suggest something like POINTER_PRINT and
PTRDIFF_PRINT and as Dean says, normal spacing.

http://codereview.chromium.org/113199/diff/1/5
File src/runtime.cc (right):

http://codereview.chromium.org/113199/diff/1/5#newcode4445
Line 4445: // TODO(x64): Definitly!
spolling!

http://codereview.chromium.org/113199/diff/1/7
File src/x64/cpu-x64.cc (right):

http://codereview.chromium.org/113199/diff/1/7#newcode49
Line 49: // If flushing of the instruction cache becomes necessary Windows have
the
have->has

[Lasse Reichstein, 2009-05-12 10:32:51]

http://codereview.chromium.org/113199/diff/1/2
File src/disassembler.cc (right):

http://codereview.chromium.org/113199/diff/1/2#newcode46
Line 46: PrintF("%"V8PRIp"  %4"V8PRId"  %02x\n", pc, pc - begin, *pc);
A quick look at what people do with PRId64 and likes from inttypes.h suggests
spaces around. I have added them where we have used the macro.

http://codereview.chromium.org/113199/diff/1/2#newcode46
Line 46: PrintF("%"V8PRIp"  %4"V8PRId"  %02x\n", pc, pc - begin, *pc);
It shouldn't say "print a pointer difference". It should say "print a
pointer-size value as decimal". I admit that it doesn't say that either.
The corresponding standard macros are called, e.g., PRIdPTR, so we should call
it something like V8PRIdPTR for consistency.

http://codereview.chromium.org/113199/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/113199/diff/1/4#newcode6729
Line 6729: static_cast<uint32_t>(reinterpret_cast<uintptr_t>(map));
Added

http://codereview.chromium.org/113199/diff/1/5
File src/runtime.cc (right):

http://codereview.chromium.org/113199/diff/1/5#newcode4448
Line 4448: #ifdef V8_HOST_ARCH_64_BIT
Done