Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: src/runtime.cc

Issue 113199: X64: General fixes - added inline definitions and changed tome places to intptr_t. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index bf6286fe34b66980f13458f098e1f5bc6defaf01..8c3ff89bca5fe13a59a0e51bebd7eb69027b3450 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -4442,10 +4442,16 @@ static Object* Runtime_LookupContext(Arguments args) {
// compiler to do the right thing.
//
// TODO(1236026): This is a non-portable hack that should be removed.
+// TODO(x64): Definitly!
Erik Corry 2009/05/12 09:24:50 spolling!
typedef uint64_t ObjectPair;
static inline ObjectPair MakePair(Object* x, Object* y) {
+#ifdef V8_HOST_ARCH_64_BIT
Dean McNamee 2009/05/12 08:22:40 I have just been doing #if, we should be consisten
Lasse Reichstein 2009/05/12 10:32:51 Done
+ UNIMPLEMENTED();
+ return 0;
+#else
return reinterpret_cast<uint32_t>(x) |
(reinterpret_cast<ObjectPair>(y) << 32);
+#endif
}
@@ -6031,6 +6037,11 @@ static Object* Runtime_GetCFrames(Arguments args) {
Object* result = Runtime_CheckExecutionState(args);
if (result->IsFailure()) return result;
+#ifdef V8_HOST_ARCH_64_BIT
Dean McNamee 2009/05/12 08:22:40 #if
+ UNIMPLEMENTED();
+ return Heap::undefined_value();
+#else
+
static const int kMaxCFramesSize = 200;
ScopedVector<OS::StackFrame> frames(kMaxCFramesSize);
int frames_count = OS::StackWalk(frames);
@@ -6062,6 +6073,7 @@ static Object* Runtime_GetCFrames(Arguments args) {
frames_array->set(i, *frame_value);
}
return *Factory::NewJSArrayWithElements(frames_array);
+#endif // V8_HOST_ARCH_64_BIT
}

Powered by Google App Engine
This is Rietveld 408576698