X64: General fixes - added inline definitions and changed tome places to intptr_t.

src/disassembler.cc

Index: src/disassembler.cc
diff --git a/src/disassembler.cc b/src/disassembler.cc
index a838a08ffba1c4c92fcf87b7269dc4a827e1c8af..c658c95f6cf6a61d50aa710f1c51e6d3890d4ddd 100644
--- a/src/disassembler.cc
+++ b/src/disassembler.cc
@@ -43,9 +43,10 @@ namespace v8 { namespace internal {
 void Disassembler::Dump(FILE* f, byte* begin, byte* end) {
   for (byte* pc = begin; pc < end; pc++) {
     if (f == NULL) {
-      PrintF("%p  %4d  %02x\n", pc, pc - begin, *pc);
+      PrintF("%"V8PRIp"  %4"V8PRId"  %02x\n", pc, pc - begin, *pc);

[Dean McNamee, 2009/05/12 08:22:40]

should we put space around these?  It looks weird, but I guess it will look
weird no matter what.

[Erik Corry, 2009/05/12 09:24:50]

I think the names are way too cryptic considering they are not used all that
many places.  The name V8PRId does not say "use this where you want to print a
ptrdiff_t" to me.  I would suggest something like POINTER_PRINT and
PTRDIFF_PRINT and as Dean says, normal spacing.

[Lasse Reichstein, 2009/05/12 10:32:51]

A quick look at what people do with PRId64 and likes from inttypes.h suggests
spaces around. I have added them where we have used the macro.

[Lasse Reichstein, 2009/05/12 10:32:51]

It shouldn't say "print a pointer difference". It should say "print a
pointer-size value as decimal". I admit that it doesn't say that either.
The corresponding standard macros are called, e.g., PRIdPTR, so we should call
it something like V8PRIdPTR for consistency.

     } else {
-      fprintf(f, "%p  %4d  %02x\n", pc, pc - begin, *pc);
+      fprintf(f, "%"V8PRIp"  %4"V8PRId"  %02x\n",
+              reinterpret_cast<uintptr_t>(pc), pc - begin, *pc);
     }
   }
 }
@@ -144,8 +145,8 @@ static int DecodeIt(FILE* f,
         // raw pointer embedded in code stream, e.g., jump table
         byte* ptr = *reinterpret_cast<byte**>(pc);
         OS::SNPrintF(decode_buffer,
-                     "%08x      jump table entry %4d",
-                     reinterpret_cast<int32_t>(ptr),
+                     "%08"V8PRIp"      jump table entry %4"V8PRId,
+                     ptr,
                      ptr - begin);
         pc += 4;
       } else {