X64: Changed TickSample to hold pointer-sized values for registers.

src/platform-win32.cc

Index: src/platform-win32.cc
diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index 597a21716b2b655e4962b7b55b6ccb76d57ecc15..eeaea700f0a6a50106bce0227bda0cce273b92b6 100644
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -1775,9 +1775,16 @@ class Sampler::PlatformData : public Malloced {
         context.ContextFlags = CONTEXT_FULL;
         GetThreadContext(profiled_thread_, &context);
         // Invoke tick handler with program counter and stack pointer.
+#if V8_HOST_ARCH_64_BIT

[Dean McNamee, 2009/05/07 08:34:08]

shouldn't we check for X64 here.

[Lasse Reichstein, 2009/05/07 09:06:01]

No, this is really the host system's registers, not the target system's
(potentially simulated) ones.

[Dean McNamee, 2009/05/07 09:19:06]

Yes, we have both V8_HOST_ARCH_X64 and V8_TARGET_ARCH_X64.  I was suggesting we
use V8_HOST_ARCH_X64 instead of V8_HOST_ARCH_64_BIT.  After all, they are x86-64
registers

[Lasse Reichstein, 2009/05/12 08:17:20]

Done.

+        UNIMPLEMENTED();

[William Hesse, 2009/05/07 09:27:50]

Shouldn't UNIMPLEMENTED() be removed, if this code is supposed to be correct?

[William Hesse, 2009/05/07 09:27:50]

Shouldn't UNIMPLEMENTED() be removed, if this code is supposed to be correct?

+        sample.pc = context.Rip;
+        sample.sp = context.Rsp;
+        sample.fp = context.Rbp;
+#else
         sample.pc = context.Eip;
         sample.sp = context.Esp;
         sample.fp = context.Ebp;
+#endif
       }
 
       // We always sample the VM state.