Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: src/log.cc

Issue 113094: X64: Changed TickSample to hold pointer-sized values for registers. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/platform.h » ('j') | src/platform-win32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 8a2fbb7dcbd05cf4cc6519735b15717e6ba7e5c1..36488515a055d71964da5f3dcc31af707fc623da 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1082,13 +1082,13 @@ void Logger::DebugEvent(const char* event_type, Vector<uint16_t> parameter) {
void Logger::TickEvent(TickSample* sample, bool overflow) {
if (!Log::is_enabled() || !FLAG_prof) return;
LogMessageBuilder msg;
- msg.Append("tick,0x%x,0x%x,%d", sample->pc, sample->sp,
+ msg.Append("tick,0x%p,0x%p,%d", sample->pc, sample->sp,
Dean McNamee 2009/05/07 08:34:08 I realize this is our own StringStream, but just F
Lasse Reichstein 2009/05/07 09:06:01 Yes, it needs to be changed. Will do that in anoth
static_cast<int>(sample->state));
if (overflow) {
msg.Append(",overflow");
}
for (int i = 0; i < sample->frames_count; ++i) {
- msg.Append(",0x%x", reinterpret_cast<uint32_t>(sample->stack[i]));
+ msg.Append(",0x%p", reinterpret_cast<uint32_t>(sample->stack[i]));
Dean McNamee 2009/05/07 08:34:08 why are you usin %p for a non-pointer?
Lasse Reichstein 2009/05/07 09:06:01 Because I forgot to remove the cast. Good catch.
}
msg.Append('\n');
msg.WriteToLogFile();
« no previous file with comments | « no previous file | src/platform.h » ('j') | src/platform-win32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698