X64: Changed TickSample to hold pointer-sized values for registers.

src/platform-win32.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1757 matching lines @@
     while (sampler_->IsActive()) {
       TickSample sample;
 
       // If profiling, we record the pc and sp of the profiled thread.
       if (sampler_->IsProfiling()) {
         // Pause the profiled thread and get its context.
         SuspendThread(profiled_thread_);
         context.ContextFlags = CONTEXT_FULL;
         GetThreadContext(profiled_thread_, &context);
         // Invoke tick handler with program counter and stack pointer.
+#if V8_HOST_ARCH_64_BIT

[Dean McNamee, 2009/05/07 08:34:08]

shouldn't we check for X64 here.

[Lasse Reichstein, 2009/05/07 09:06:01]

No, this is really the host system's registers, not the target system's
(potentially simulated) ones.

[Dean McNamee, 2009/05/07 09:19:06]

Yes, we have both V8_HOST_ARCH_X64 and V8_TARGET_ARCH_X64.  I was suggesting we
use V8_HOST_ARCH_X64 instead of V8_HOST_ARCH_64_BIT.  After all, they are x86-64
registers

[Lasse Reichstein, 2009/05/12 08:17:20]

Done.

+        UNIMPLEMENTED();

[William Hesse, 2009/05/07 09:27:50]

Shouldn't UNIMPLEMENTED() be removed, if this code is supposed to be correct?

[William Hesse, 2009/05/07 09:27:50]

Shouldn't UNIMPLEMENTED() be removed, if this code is supposed to be correct?

+        sample.pc = context.Rip;
+        sample.sp = context.Rsp;
+        sample.fp = context.Rbp;
+#else
         sample.pc = context.Eip;
         sample.sp = context.Esp;
         sample.fp = context.Ebp;
+#endif
       }
 
       // We always sample the VM state.
       sample.state = Logger::state();
       sampler_->Tick(&sample);
 
       if (sampler_->IsProfiling()) {
         ResumeThread(profiled_thread_);
       }
 
@@ skipping 65 matching lines @@
 
   // Release the thread handles
   CloseHandle(data_->sampler_thread_);
   CloseHandle(data_->profiled_thread_);
 }
 
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 } }  // namespace v8::internal