Issue 11198018: Move ChannelLayout into media namespace.

Issue 11198018: Move ChannelLayout into media namespace. (Closed)

Created:
8 years, 2 months ago by DaleCurtis

Modified:
8 years, 2 months ago

Reviewers:
jam, Ami GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Satish, jam, feature-media-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move ChannelLayout into media namespace. Also moves kChannelOrderings extern into a function for export compatibility with MSVC++ and the shared_memory_support target. BUG=none TEST=compiles.

Patch Set 4 : Fixes. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -70 lines)			Patch
M	content/browser/renderer_host/media/audio_renderer_host_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/speech/speech_recognizer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/speech/speech_recognizer.cc	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/common/media/audio_param_traits.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1 2 3	3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/media/audio_hardware.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/audio_hardware.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/media/audio_renderer_mixer_manager_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/webrtc_audio_device_impl.cc	View	1 2 3	6 chunks	+8 lines, -7 lines	0 comments	Download
M	content/renderer/media/webrtc_audio_device_unittest.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_input_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_output_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	content/test/webrtc_audio_device_test.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/test/webrtc_audio_device_test.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	media/audio/mac/audio_output_mac.cc	View	1 2	4 chunks	+19 lines, -17 lines	0 comments	Download
M	media/base/audio_bus_unittest.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/base/channel_layout.h	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	media/base/channel_layout.cc	View	1 2	3 chunks	+21 lines, -1 line	0 comments	Download
M	media/mp4/aac.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

Argh, yak shave! Ideally the ChannelLayout stuff would move into its own channel_layout name space, ...

8 years, 2 months ago (2012-10-17 01:24:30 UTC) #1

Ami GONE FROM CHROMIUM

media::LGTM https://codereview.chromium.org/11198018/diff/1/media/base/channel_layout.cc File media/base/channel_layout.cc (right): https://codereview.chromium.org/11198018/diff/1/media/base/channel_layout.cc#newcode96 media/base/channel_layout.cc:96: return kChannelOrderings[layout][channel]; Could DCHECK_LT(layout, arraysize(kChannelOrderings)); DCHECK_LT(channel, arraysize(kChannelOrderings[0])); if ...

8 years, 2 months ago (2012-10-17 03:54:49 UTC) #2

DaleCurtis

http://codereview.chromium.org/11198018/diff/1/media/base/channel_layout.cc File media/base/channel_layout.cc (right): http://codereview.chromium.org/11198018/diff/1/media/base/channel_layout.cc#newcode96 media/base/channel_layout.cc:96: return kChannelOrderings[layout][channel]; On 2012/10/17 03:54:49, Ami Fischman wrote: > ...

8 years, 2 months ago (2012-10-17 04:22:13 UTC) #3

jam

lgtm https://codereview.chromium.org/11198018/diff/3004/content/common/view_messages.h File content/common/view_messages.h (right): https://codereview.chromium.org/11198018/diff/3004/content/common/view_messages.h#newcode63 content/common/view_messages.h:63: IPC_ENUM_TRAITS(media::ChannelLayout) nit: reorder https://codereview.chromium.org/11198018/diff/3004/content/renderer/media/audio_hardware.cc File content/renderer/media/audio_hardware.cc (right): https://codereview.chromium.org/11198018/diff/3004/content/renderer/media/audio_hardware.cc#newcode12 ...

8 years, 2 months ago (2012-10-17 15:06:35 UTC) #4

DaleCurtis

8 years, 2 months ago (2012-10-17 18:51:20 UTC) #5

https://codereview.chromium.org/11198018/diff/3004/content/common/view_messag...
File content/common/view_messages.h (right):

https://codereview.chromium.org/11198018/diff/3004/content/common/view_messag...
content/common/view_messages.h:63: IPC_ENUM_TRAITS(media::ChannelLayout)
On 2012/10/17 15:06:35, John Abd-El-Malek wrote:
> nit: reorder

Done.

https://codereview.chromium.org/11198018/diff/3004/content/renderer/media/aud...
File content/renderer/media/audio_hardware.cc (right):

https://codereview.chromium.org/11198018/diff/3004/content/renderer/media/aud...
content/renderer/media/audio_hardware.cc:12: using media::CHANNEL_LAYOUT_NONE;
On 2012/10/17 15:06:35, John Abd-El-Malek wrote:
> nit: here and in other files, why do this? in most other places you use the
enum
> values prefixed with media namespace

Laziness after a frustrating shave, sorry. Fixed.

Expand Messages | Collapse Messages