Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: media/base/channel_layout.h

Issue 11198018: Move ChannelLayout into media namespace. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixes. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_bus_unittest.cc ('k') | media/base/channel_layout.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/channel_layout.h
diff --git a/media/base/channel_layout.h b/media/base/channel_layout.h
index aa281698d42f06b774c8dcea52d9aff192f7e43d..503f93a44f52b17eaa7210f8dc6f08b875b011bb 100644
--- a/media/base/channel_layout.h
+++ b/media/base/channel_layout.h
@@ -7,6 +7,8 @@
#include "media/base/media_export.h"
+namespace media {
+
// Enumerates the various representations of the ordering of audio channels.
// Logged to UMA, so never reuse a value, always add new/greater ones!
enum ChannelLayout {
@@ -79,16 +81,14 @@ enum Channels {
CHANNELS_MAX
};
-// The channel orderings for each layout as specified by FFmpeg.
-// Values represent the index of each channel in each layout. For example, the
-// left side surround sound channel in FFmpeg's 5.1 layout is in the 5th
-// position (because the order is L, R, C, LFE, LS, RS), so
-// kChannelOrderings[CHANNEL_LAYOUT_5POINT1][SIDE_LEFT] = 4;
-// Values of -1 mean the channel at that index is not used for that layout.
-MEDIA_EXPORT extern const int
-kChannelOrderings[CHANNEL_LAYOUT_MAX][CHANNELS_MAX];
+// Returns the expected channel position in an interleaved stream. Values of -1
+// mean the channel at that index is not used for that layout. Values range
+// from 0 to CHANNELS_MAX - 1.
+MEDIA_EXPORT int ChannelOrder(ChannelLayout layout, Channels channel);
// Returns the number of channels in a given ChannelLayout.
MEDIA_EXPORT int ChannelLayoutToChannelCount(ChannelLayout layout);
+} // namespace media
+
#endif // MEDIA_BASE_CHANNEL_LAYOUT_H_
« no previous file with comments | « media/base/audio_bus_unittest.cc ('k') | media/base/channel_layout.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698