[Android] Upstream external_protocol_dialog_android.cc

chrome/browser/android/tab_android.h

Index: chrome/browser/android/tab_android.h
diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h
index bc52a537d267e99d85be7c61439ce3c3016a2f26..e82a0e9c7fc048592ad3292b5362b22101a2af90 100644
--- a/chrome/browser/android/tab_android.h
+++ b/chrome/browser/android/tab_android.h
@@ -7,7 +7,6 @@
 
 #include <jni.h>
 
-#include "base/android/jni_helper.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/callback_forward.h"
 #include "base/string16.h"
@@ -67,6 +66,10 @@ class TabAndroid {
       const GURL& url, const string16& title, const SkBitmap& skbitmap,
       int r_value, int g_value, int b_value) = 0;
 
+  // Called when the common ExternalProtocolHandler wants to
+  // run the external protocol dialog.

[Ted C, 2012/10/16 22:58:15]

is run the right word here?  is display/show better?

[newt (away), 2012/10/16 23:19:42]

This is the function name used elsewhere, e.g. external_protocol_handler.h and
other platform-specific implementations.  Do you still think it should be
changed?

[Ted C, 2012/10/16 23:25:10]

Sigh...I guess it's better to be consistent.

+  virtual void RunExternalProtocolDialog(const GURL& url) = 0;
+
  protected:
   virtual ~TabAndroid();