Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/android/tab_base_android_impl.h

Issue 11193014: [Android] Upstream external_protocol_dialog_android.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_base_android_impl.h
diff --git a/chrome/browser/android/tab_base_android_impl.h b/chrome/browser/android/tab_base_android_impl.h
index 7964a8c4982e5afbd3981a659a737ac301246c75..3286cded5cded273e985f7da99244572468681b2 100644
--- a/chrome/browser/android/tab_base_android_impl.h
+++ b/chrome/browser/android/tab_base_android_impl.h
@@ -60,6 +60,10 @@ class TabBaseAndroidImpl : public TabAndroid {
int g_value,
int b_value) OVERRIDE;
+ // Called when the common ExternalProtocolHandler wants to
+ // run the external protocol dialog.
Ted C 2012/10/16 23:25:10 also, I would leave this comment out of the impl.h
newt (away) 2012/10/16 23:29:50 Done.
+ virtual void RunExternalProtocolDialog(const GURL& url) OVERRIDE;
+
// Register the Tab's native methods through JNI.
static bool RegisterTabBaseAndroidImpl(JNIEnv* env);

Powered by Google App Engine
This is Rietveld 408576698