[Android] Upstream external_protocol_dialog_android.cc

chrome/browser/android/tab_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
 
 #include <jni.h>
 
-#include "base/android/jni_helper.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/callback_forward.h"
 #include "base/string16.h"
 
 class GURL;
 class SkBitmap;
 class TabContents;
 
 namespace browser_sync {
 class SyncedTabDelegate;
@@ skipping 39 matching lines @@
   virtual void ShowCustomContextMenu(
       const content::ContextMenuParams& params,
       const base::Callback<void(int)>& callback) = 0;
 
   // Called when context menu option to create the bookmark shortcut on
   // homescreen is called.
   virtual void AddShortcutToBookmark(
       const GURL& url, const string16& title, const SkBitmap& skbitmap,
       int r_value, int g_value, int b_value) = 0;
 
+  // Called when the common ExternalProtocolHandler wants to
+  // run the external protocol dialog.

[Ted C, 2012/10/16 22:58:15]

is run the right word here?  is display/show better?

[newt (away), 2012/10/16 23:19:42]

This is the function name used elsewhere, e.g. external_protocol_handler.h and
other platform-specific implementations.  Do you still think it should be
changed?

[Ted C, 2012/10/16 23:25:10]

Sigh...I guess it's better to be consistent.

+  virtual void RunExternalProtocolDialog(const GURL& url) = 0;
+
  protected:
   virtual ~TabAndroid();
 
   int tab_id_;
 };
 
 #endif  // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_