chrome/browser/extensions/api/tabs/tabs.cc - Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More include issues Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc ('K') | « chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc ('k') | chrome/browser/prefs/pref_service_browsertest.cc » ('j') | chrome/browser/prefs/pref_service_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc

index 20053f91cd7c6a74baf43963377a03fbb718437e..bcafa401a8dbef2303618b3608c3b36992d05956 100644

--- a/chrome/browser/extensions/api/tabs/tabs.cc

+++ b/chrome/browser/extensions/api/tabs/tabs.cc

@@ -531,9 +531,12 @@ bool CreateWindowFunction::RunImpl() {

// NOTE(rafaelw): It's ok if GetCurrentBrowser() returns NULL here.

// GetBrowserWindowBounds will default to saved "default" values for

// the app.

- WindowSizer::GetBrowserWindowBounds(std::string(), gfx::Rect(),

- GetCurrentBrowser(),

- &window_bounds);

+ ui::WindowShowState show_state;

sky 2012/10/08 21:01:25 Same comment about initializing here.

Mr4D (OOO till 08-26) 2012/10/08 23:04:27 Yeah, done.

+ WindowSizer::GetBrowserWindowBoundsAndShowState(std::string(),

+ gfx::Rect(),

+ GetCurrentBrowser(),

+ &window_bounds,

+ &show_state);

}

if (Browser::TYPE_PANEL == window_type &&