Combined window positioning and show state determiniation in the WindowSizer

chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
index 74655c04483c7c12fdc42a9960e6d59901ed74be..76ecf882aab8076aa13d1a252eff31b8f84bf4e1 100644
--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc
@@ -488,8 +488,9 @@ bool CreateOffscreenTabFunction::RunImpl() {
     return false;
   }
 
-  WindowSizer::GetBrowserWindowBounds(
-      std::string(), gfx::Rect(), browser, &window_bounds);
+  ui::WindowShowState show_state;

[sky, 2012/10/08 21:01:25]

Explicitly initialize show_state here. I realize you're not using, but less
error prone in the future.

[Mr4D (OOO till 08-26), 2012/10/08 23:04:27]

Since it *always* get overridden I thought this is not necessary, but okay -
Done (in 4 different files)!

+  WindowSizer::GetBrowserWindowBoundsAndShowState(
+      std::string(), gfx::Rect(), browser, &window_bounds, &show_state);
 
   int width = window_bounds.width();
   if (create_props->HasKey(tabs_keys::kWidthKey))