Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3222)

Unified Diff: chrome/browser/prefs/pref_service_browsertest.cc

Issue 11072002: Combined window positioning and show state determiniation in the WindowSizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More include issues Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_service_browsertest.cc
diff --git a/chrome/browser/prefs/pref_service_browsertest.cc b/chrome/browser/prefs/pref_service_browsertest.cc
index a49ab22900152c872f94ff4722f7b65153e16b41..7abb489ae7f88007ef6804c8cd0c82cfcd40bb0f 100644
--- a/chrome/browser/prefs/pref_service_browsertest.cc
+++ b/chrome/browser/prefs/pref_service_browsertest.cc
@@ -23,6 +23,10 @@
#include "chrome/test/base/ui_test_utils.h"
#include "ui/gfx/rect.h"
+#if defined(USE_AURA)
sky 2012/10/08 21:01:25 This shouldn't be needed.
Mr4D (OOO till 08-26) 2012/10/08 23:04:27 Right - not anymore! Done.
+#include "ui/aura/window.h"
+#endif
+
// On GTK, resizing happens asynchronously and we currently don't have a way to
// get called back (it's probably possible, but we don't have that code). Since
// the GTK code is going away, not spending more time on this.
@@ -142,8 +146,7 @@ IN_PROC_BROWSER_TEST_F(PreservedWindowPlacementIsLoaded, Test) {
EXPECT_EQ(right, bounds.x() + bounds.width());
// Find if launched window is maximized.
- bool is_window_maximized =
- chrome::GetSavedWindowShowState(browser()) == ui::SHOW_STATE_MAXIMIZED;
+ bool is_window_maximized = browser()->window()->IsMaximized();
bool is_maximized = false;
EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized",
&is_maximized));
@@ -201,8 +204,7 @@ IN_PROC_BROWSER_TEST_F(PreservedWindowPlacementIsMigrated, Test) {
EXPECT_EQ(right, bounds.x() + bounds.width());
// Find if launched window is maximized.
- bool is_window_maximized =
- chrome::GetSavedWindowShowState(browser()) == ui::SHOW_STATE_MAXIMIZED;
+ bool is_window_maximized = browser()->window()->IsMaximized();
bool is_maximized = false;
EXPECT_TRUE(root_dict->GetBoolean(kBrowserWindowPlacement + ".maximized",
&is_maximized));

Powered by Google App Engine
This is Rietveld 408576698