Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: lib/core/map.dart

Issue 10979050: Ensure that hashCode and runtimeType work on null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix HashMap. Update bad expectation. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/coreimpl/hash_map_set.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/core/map.dart
diff --git a/lib/core/map.dart b/lib/core/map.dart
index 98519c949a7e93b4ab888f8ba5f895d2d425bf3d..cc3a01ed03dca482218e96ebb3cf26d69b041e7c 100644
--- a/lib/core/map.dart
+++ b/lib/core/map.dart
@@ -4,7 +4,7 @@
/**
* A [Map] is an associative container, mapping a key to a value.
- * Null values are supported.
+ * Null values are supported, but null keys are not.
ahe 2012/09/27 09:38:51 Why have this limitation?
Lasse Reichstein Nielsen 2012/09/27 09:55:37 It was always there. The code as written assumed n
ahe 2012/09/27 10:17:21 You're changing the specification in this CL. I th
Lasse Reichstein Nielsen 2012/09/27 10:35:53 I don't think I'm changing the specification. Sayi
ahe 2012/09/27 10:45:33 This all sounds like something that needs to be re
*/
interface Map<K, V> default HashMapImplementation<K extends Hashable, V> {
/**
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/coreimpl/hash_map_set.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698