Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: lib/core/map.dart

Issue 10979050: Ensure that hashCode and runtimeType work on null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix HashMap. Update bad expectation. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/coreimpl/hash_map_set.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A [Map] is an associative container, mapping a key to a value. 6 * A [Map] is an associative container, mapping a key to a value.
7 * Null values are supported. 7 * Null values are supported, but null keys are not.
ahe 2012/09/27 09:38:51 Why have this limitation?
Lasse Reichstein Nielsen 2012/09/27 09:55:37 It was always there. The code as written assumed n
ahe 2012/09/27 10:17:21 You're changing the specification in this CL. I th
Lasse Reichstein Nielsen 2012/09/27 10:35:53 I don't think I'm changing the specification. Sayi
ahe 2012/09/27 10:45:33 This all sounds like something that needs to be re
8 */ 8 */
9 interface Map<K, V> default HashMapImplementation<K extends Hashable, V> { 9 interface Map<K, V> default HashMapImplementation<K extends Hashable, V> {
10 /** 10 /**
11 * Creates a map with the default implementation. 11 * Creates a map with the default implementation.
12 */ 12 */
13 Map(); 13 Map();
14 14
15 /** 15 /**
16 * Creates a [Map] that contains all key value pairs of [other]. 16 * Creates a [Map] that contains all key value pairs of [other].
17 */ 17 */
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 /** 114 /**
115 * Creates a map with the default implementation. 115 * Creates a map with the default implementation.
116 */ 116 */
117 LinkedHashMap(); 117 LinkedHashMap();
118 118
119 /** 119 /**
120 * Creates a [LinkedHashMap] that contains all key value pairs of [other]. 120 * Creates a [LinkedHashMap] that contains all key value pairs of [other].
121 */ 121 */
122 LinkedHashMap.from(Map<K, V> other); 122 LinkedHashMap.from(Map<K, V> other);
123 } 123 }
OLDNEW
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/coreimpl/hash_map_set.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698