Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10979050: Ensure that hashCode and runtimeType work on null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix HashMap. Update bad expectation. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index 98a024761753ec356b57beb9e8f65147e2c8fc24..35582749429c9f0d308542346b97609a4762398a 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -47,6 +47,8 @@ class Interceptors {
// use this function.
Element getStaticInterceptorBySelector(Selector selector) {
if (selector.isGetter()) {
+ // TODO(lrn): If there is no get-interceptor, but there is a
+ // method-interceptor, we should generate a get-interceptor automatically.
return getStaticGetInterceptor(selector.name);
} else if (selector.isSetter()) {
return getStaticSetInterceptor(selector.name);

Powered by Google App Engine
This is Rietveld 408576698