Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: webkit/fileapi/file_writer_delegate_unittest.cc

Issue 10956064: Send OnModifyFile Notification when File Write Finishes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added write status inside FileWriteDelegate so onFileModify notifications are only sent when a file… Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_writer_delegate_unittest.cc
diff --git a/webkit/fileapi/file_writer_delegate_unittest.cc b/webkit/fileapi/file_writer_delegate_unittest.cc
index edce01702673d509043b223945226b651a3eba61..03d8008ba75fb9978c11e1e21073ea76412666fa 100644
--- a/webkit/fileapi/file_writer_delegate_unittest.cc
+++ b/webkit/fileapi/file_writer_delegate_unittest.cc
@@ -42,8 +42,10 @@ class Result {
int64 bytes_written() const { return bytes_written_; }
bool complete() const { return complete_; }
kinuko 2012/09/25 14:00:49 Can we change this to return WriteCompletionStatus
calvinlo 2012/09/26 05:23:07 Done. Please note that a lot more lines in this fi
- void DidWrite(base::PlatformFileError status, int64 bytes, bool complete) {
+ void DidWrite(base::PlatformFileError status, int64 bytes,
+ FileWriterDelegate::WriteCompletionStatus write_status) {
if (status == base::PLATFORM_FILE_OK) {
+ bool complete = (write_status != FileWriterDelegate::NOT_COMPLETE);
add_bytes_written(bytes, complete);
if (complete)
MessageLoop::current()->Quit();

Powered by Google App Engine
This is Rietveld 408576698