Send OnModifyFile Notification when File Write Finishes

webkit/fileapi/file_writer_delegate_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/message_loop.h"
@@ skipping 22 matching lines @@
         bytes_written_(0),
         complete_(false) {}
 
   base::PlatformFileError status() const { return status_; }
   void add_bytes_written(int64 bytes, bool complete) {
     bytes_written_ += bytes;
     EXPECT_FALSE(complete_);
     complete_ = complete;
   }
   int64 bytes_written() const { return bytes_written_; }
   bool complete() const { return complete_; }

[kinuko, 2012/09/25 14:00:49]

Can we change this to return WriteCompletionStatus so that we can check the
completion status more specifically?

[calvinlo, 2012/09/26 05:23:07]

Done. Please note that a lot more lines in this file have been changed because
of the conversion of (bool complete_) to (WriteProgressStatus write_status_).

 
-  void DidWrite(base::PlatformFileError status, int64 bytes, bool complete) {
+  void DidWrite(base::PlatformFileError status, int64 bytes,
+                FileWriterDelegate::WriteCompletionStatus write_status) {
     if (status == base::PLATFORM_FILE_OK) {
+      bool complete = (write_status != FileWriterDelegate::NOT_COMPLETE);
       add_bytes_written(bytes, complete);
       if (complete)
         MessageLoop::current()->Quit();
     } else {
       EXPECT_FALSE(complete_);
       EXPECT_EQ(status_, base::PLATFORM_FILE_OK);
       complete_ = true;
       status_ = status;
       MessageLoop::current()->Quit();
     }
@@ skipping 400 matching lines @@
   file_writer_delegate_.reset();
 
   EXPECT_EQ(pre_write_usage + allowed_growth,
             test_helper_.GetCachedOriginUsage());
   EXPECT_EQ(ComputeCurrentOriginUsage(), test_helper_.GetCachedOriginUsage());
   EXPECT_EQ(kOverlap + allowed_growth, result_->bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_NO_SPACE, result_->status());
 }
 
 }  // namespace fileapi