Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webkit/fileapi/local_file_system_operation.h

Issue 10956064: Send OnModifyFile Notification when File Write Finishes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added write status inside FileWriteDelegate so onFileModify notifications are only sent when a file… Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/local_file_system_operation.h
diff --git a/webkit/fileapi/local_file_system_operation.h b/webkit/fileapi/local_file_system_operation.h
index e4ba5412d4382662f69523e17018530fa6d35703..357d91a86366d09a1e906f9bda8ef9ffde3cc75b 100644
--- a/webkit/fileapi/local_file_system_operation.h
+++ b/webkit/fileapi/local_file_system_operation.h
@@ -20,6 +20,8 @@
#include "webkit/fileapi/file_system_operation_context.h"
#include "webkit/fileapi/file_system_types.h"
#include "webkit/fileapi/file_system_url.h"
+#include "webkit/fileapi/file_writer_delegate.h"
+#include "webkit/quota/quota_manager.h"
kinuko 2012/09/25 14:00:49 please sort headers.
tzik 2012/09/26 01:41:12 maybe, quota_manager.h is not needed here.
calvinlo 2012/09/26 05:23:07 Oops, good catch. Removing second include call. Th
#include "webkit/fileapi/fileapi_export.h"
#include "webkit/quota/quota_manager.h"
@@ -214,9 +216,10 @@ class FILEAPI_EXPORT LocalFileSystemOperation
base::PlatformFileError rv,
const std::vector<base::FileUtilProxy::Entry>& entries,
bool has_more);
- void DidWrite(base::PlatformFileError rv,
+ void DidWrite(const FileSystemURL& url,
+ base::PlatformFileError rv,
int64 bytes,
- bool complete);
+ FileWriterDelegate::WriteCompletionStatus write_status);
void DidTouchFile(const StatusCallback& callback,
base::PlatformFileError rv);
void DidOpenFile(const OpenFileCallback& callback,

Powered by Google App Engine
This is Rietveld 408576698