Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1092003: Fixed a lot of bugs with render surfaces and bitmaps. (Closed)

Created:
10 years, 9 months ago by petersont
Modified:
9 years, 7 months ago
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Implemented Texture2D.drawImage, along the way cleaned up a number of lingering bugs, moved some texture initialization so subsequent calls to gl.texSubImage2D wouldn't fail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42277

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -84 lines) Patch
M samples/o3d-webgl-samples/shadow-map.html View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M samples/o3d-webgl/bitmap.js View 1 2 chunks +19 lines, -0 lines 0 comments Download
M samples/o3d-webgl/bounding_box.js View 4 chunks +4 lines, -4 lines 0 comments Download
M samples/o3d-webgl/buffer.js View 4 chunks +4 lines, -4 lines 0 comments Download
M samples/o3d-webgl/client.js View 1 5 chunks +22 lines, -4 lines 0 comments Download
M samples/o3d-webgl/draw_list.js View 1 chunk +1 line, -1 line 0 comments Download
M samples/o3d-webgl/effect.js View 1 2 7 chunks +88 lines, -24 lines 0 comments Download
M samples/o3d-webgl/pack.js View 1 chunk +11 lines, -10 lines 0 comments Download
M samples/o3d-webgl/param.js View 1 2 1 chunk +17 lines, -4 lines 0 comments Download
M samples/o3d-webgl/primitive.js View 3 chunks +7 lines, -0 lines 0 comments Download
M samples/o3d-webgl/render_surface_set.js View 1 chunk +1 line, -1 line 0 comments Download
M samples/o3d-webgl/shape.js View 3 chunks +14 lines, -2 lines 0 comments Download
M samples/o3d-webgl/state.js View 4 chunks +9 lines, -13 lines 0 comments Download
M samples/o3d-webgl/texture.js View 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
petersont
10 years, 9 months ago (2010-03-18 22:32:07 UTC) #1
Ken Russell (switch to Gerrit)
LGTM http://codereview.chromium.org/1092003/diff/2001/3014 File samples/o3d-webgl-samples/shadow-map.html (right): http://codereview.chromium.org/1092003/diff/2001/3014#newcode589 samples/o3d-webgl-samples/shadow-map.html:589: projCoords = 0.5 * projCoords + 0.5; extra ...
10 years, 9 months ago (2010-03-18 23:56:45 UTC) #2
petersont
10 years, 9 months ago (2010-03-22 23:02:21 UTC) #3
http://codereview.chromium.org/1092003/diff/2001/3014
File samples/o3d-webgl-samples/shadow-map.html (right):

http://codereview.chromium.org/1092003/diff/2001/3014#newcode589
samples/o3d-webgl-samples/shadow-map.html:589: projCoords =  0.5 * projCoords +
0.5;
On 2010/03/18 23:56:45, kbr wrote:
> extra space between = and 0.5.
> 

Done.

http://codereview.chromium.org/1092003/diff/2001/3012
File samples/o3d-webgl/param.js (right):

http://codereview.chromium.org/1092003/diff/2001/3012#newcode752
samples/o3d-webgl/param.js:752: * A counter to ensure each texture sampler gets
a unqiue id.
On 2010/03/18 23:56:45, kbr wrote:
> @private
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698