Move creation of PeerConnection from the RenderView to the RenderThreadImpl.

content/renderer/media/media_stream_impl.cc

Index: content/renderer/media/media_stream_impl.cc
diff --git a/content/renderer/media/media_stream_impl.cc b/content/renderer/media/media_stream_impl.cc
index c794f05bd4380adef63045076e1a407356d5c527..089fdc2b87cb17ca43cd0df2b55afe6c3e8587a4 100644
--- a/content/renderer/media/media_stream_impl.cc
+++ b/content/renderer/media/media_stream_impl.cc
@@ -93,23 +93,6 @@ MediaStreamImpl::~MediaStreamImpl() {
   CleanupPeerConnectionFactory();
 }
 
-WebKit::WebPeerConnection00Handler*
-MediaStreamImpl::CreatePeerConnectionHandlerJsep(
-    WebKit::WebPeerConnection00HandlerClient* client) {
-  // Save histogram data so we can see how much PeerConnetion is used.
-  // The histogram counts the number of calls to the JS API
-  // webKitPeerConnection00.
-  UpdateWebRTCMethodCount(kWebkitPeerConnection);
-  DCHECK(CalledOnValidThread());
-  if (!EnsurePeerConnectionFactory())
-    return NULL;
-
-  PeerConnectionHandlerJsep* pc_handler = new PeerConnectionHandlerJsep(
-      client,
-      dependency_factory_.get());
-  return pc_handler;
-}
-
 void MediaStreamImpl::StopLocalMediaStream(
     const WebKit::WebMediaStreamDescriptor& stream) {
   DVLOG(1) << "MediaStreamImpl::StopLocalMediaStream";
@@ -446,7 +429,7 @@ bool MediaStreamImpl::EnsurePeerConnectionFactory() {
 }
 
 void MediaStreamImpl::CleanupPeerConnectionFactory() {
-  if (dependency_factory_.get())
+  if (dependency_factory_)
     dependency_factory_->ReleasePeerConnectionFactory();

[piman, 2012/09/06 17:04:45]

Should this logic move to RenderThreadImpl? IIUC you have a one MediaStreamImpl
per RenderView, but a single dependency factory per renderer. Won't this release
the peer connection factory for all RenderViews?
If it holds resources that are important to be released once all webrtc-using
tabs are gone, you could add a refcount. If it's just a small factory object, it
having the lifetime of the renderer isn't a problem.

[perkj_chrome, 2012/09/12 13:54:38]

This have not moved to the dependency factory and there is only one per render
thread. CleanupPeerConnectionFactory is called as part of the
MediaStreamDependencyFactory dtor.

   if (network_manager_) {
     // The network manager needs to free its resources on the thread they were