Move creation of PeerConnection from the RenderView to the RenderThreadImpl.

content/renderer/media/media_stream_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 75 matching lines @@
       vc_manager_(vc_manager),
       signaling_thread_(NULL),
       worker_thread_(NULL),
       chrome_worker_thread_("Chrome_libJingle_WorkerThread") {
 }
 
 MediaStreamImpl::~MediaStreamImpl() {
   CleanupPeerConnectionFactory();
 }
 
-WebKit::WebPeerConnection00Handler*
-MediaStreamImpl::CreatePeerConnectionHandlerJsep(
-    WebKit::WebPeerConnection00HandlerClient* client) {
-  // Save histogram data so we can see how much PeerConnetion is used.
-  // The histogram counts the number of calls to the JS API
-  // webKitPeerConnection00.
-  UpdateWebRTCMethodCount(kWebkitPeerConnection);
-  DCHECK(CalledOnValidThread());
-  if (!EnsurePeerConnectionFactory())
-    return NULL;
-
-  PeerConnectionHandlerJsep* pc_handler = new PeerConnectionHandlerJsep(
-      client,
-      dependency_factory_.get());
-  return pc_handler;
-}
-
 void MediaStreamImpl::StopLocalMediaStream(
     const WebKit::WebMediaStreamDescriptor& stream) {
   DVLOG(1) << "MediaStreamImpl::StopLocalMediaStream";
 
   MediaStreamExtraData* extra_data =
       static_cast<MediaStreamExtraData*>(stream.extraData());
   if (extra_data && extra_data->local_stream()) {
     media_stream_dispatcher_->StopStream(extra_data->local_stream()->label());
     local_media_streams_.erase(extra_data->local_stream()->label());
   } else {
@@ skipping 316 matching lines @@
             socket_factory_.get())) {
       LOG(ERROR) << "Could not create PeerConnection factory";
       return false;
     }
   }
 
   return true;
 }
 
 void MediaStreamImpl::CleanupPeerConnectionFactory() {
-  if (dependency_factory_.get())
+  if (dependency_factory_)
     dependency_factory_->ReleasePeerConnectionFactory();

[piman, 2012/09/06 17:04:45]

Should this logic move to RenderThreadImpl? IIUC you have a one MediaStreamImpl
per RenderView, but a single dependency factory per renderer. Won't this release
the peer connection factory for all RenderViews?
If it holds resources that are important to be released once all webrtc-using
tabs are gone, you could add a refcount. If it's just a small factory object, it
having the lifetime of the renderer isn't a problem.

[perkj_chrome, 2012/09/12 13:54:38]

This have not moved to the dependency factory and there is only one per render
thread. CleanupPeerConnectionFactory is called as part of the
MediaStreamDependencyFactory dtor.

   if (network_manager_) {
     // The network manager needs to free its resources on the thread they were
     // created, which is the worked thread.
     if (chrome_worker_thread_.IsRunning()) {
       chrome_worker_thread_.message_loop()->PostTask(FROM_HERE, base::Bind(
           &MediaStreamImpl::DeleteIpcNetworkManager,
           base::Unretained(this)));
       // Stopping the thread will wait until all tasks have been
       // processed before returning. We wait for the above task to finish before
       // letting the the function continue to avoid any potential race issues.
@@ skipping 94 matching lines @@
 MediaStreamExtraData::MediaStreamExtraData(
     webrtc::MediaStreamInterface* remote_stream)
     : remote_stream_(remote_stream) {
 }
 MediaStreamExtraData::MediaStreamExtraData(
     webrtc::LocalMediaStreamInterface* local_stream)
     : local_stream_(local_stream) {
 }
 MediaStreamExtraData::~MediaStreamExtraData() {
 }