content/renderer/media/media_stream_impl.h - Issue 10919122: Move creation of PeerConnection from the RenderView to the RenderThreadImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_impl.h

Issue 10919122: Move creation of PeerConnection from the RenderView to the RenderThreadImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed UMA_HISTOGRAM_ENUMERATION and cleaned up. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_dependency_factory.cc ('K') | « content/renderer/media/media_stream_dependency_factory.cc ('k') | content/renderer/media/media_stream_impl.cc » ('j') | content/renderer/media/media_stream_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_impl.h

diff --git a/content/renderer/media/media_stream_impl.h b/content/renderer/media/media_stream_impl.h

index 970a2f2f768f5bda328c1d8b35feb2ba78713367..662ddade24db2c15a5d6c09e1f6de49b346c13e0 100644

--- a/content/renderer/media/media_stream_impl.h

+++ b/content/renderer/media/media_stream_impl.h

@@ -85,8 +85,6 @@ class CONTENT_EXPORT MediaStreamImpl

MediaStreamDependencyFactory* dependency_factory);

virtual ~MediaStreamImpl();

- virtual WebKit::WebPeerConnection00Handler* CreatePeerConnectionHandlerJsep(

- WebKit::WebPeerConnection00HandlerClient* client);

// Stops a local MediaStream by notifying the MediaStreamDispatcher that the

// stream no longer may be used.

virtual void StopLocalMediaStream(

@@ -192,7 +190,9 @@ class CONTENT_EXPORT MediaStreamImpl

const WebKit::WebVector<WebKit::WebMediaStreamSource>& audio_sources,

const WebKit::WebVector<WebKit::WebMediaStreamSource>& video_sources);

- scoped_ptr<MediaStreamDependencyFactory> dependency_factory_;

+ // Weak ref to a MediaStreamDependencyFactory, owned by the RenderThread.

+ // It's valid for the lifetime of RenderThread.

+ MediaStreamDependencyFactory* dependency_factory_;

// media_stream_dispatcher_ is a weak reference, owned by RenderView. It's

// valid for the lifetime of RenderView.