Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3000)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 10917274: Re-enable native UI for {frame:'chrome'} in app windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only allow {frame:'experimental-html'} when --enable-experimental-extension-apis Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index f8f89115c45d722ac8c09126472d9c61e2089680..b17114e35f6905d82d164ddd9984631ed9922d00 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -12,11 +12,10 @@ var GetView = appWindowNatives.GetView;
chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
- apiFunctions.setCustomCallback('create', function(name, request, viewId) {
+ apiFunctions.setCustomCallback('create', function(name, request, result) {
var view = null;
- if (viewId) {
- var shouldShowFrame = !request.args[1] || request.args[1].frame != 'none';
- view = GetView(viewId, !!shouldShowFrame);
+ if (result.viewId) {
+ view = GetView(result.viewId, result.injectTitlebar);
}
if (request.callback) {
request.callback(view.chrome.app.window.current());

Powered by Google App Engine
This is Rietveld 408576698