Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10917274: Re-enable native UI for {frame:'chrome'} in app windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only allow {frame:'experimental-html'} when --enable-experimental-extension-apis Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index ec6a2979077eb79c7703163b3192b00d4f190e86..4528288463d7601a26b003799eea00eec1e212d8 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -64,7 +64,7 @@ void SuspendRenderViewHost(RenderViewHost* rvh) {
} // namespace
ShellWindow::CreateParams::CreateParams()
- : frame(ShellWindow::CreateParams::FRAME_NONE),
+ : frame(ShellWindow::CreateParams::FRAME_CHROME),
bounds(-1, -1, kDefaultWidth, kDefaultHeight),
restore_position(true), restore_size(true) {
}
@@ -106,13 +106,6 @@ void ShellWindow::Init(const GURL& url,
web_contents_->GetRenderViewHost()->SyncRendererPrefs();
native_window_.reset(NativeShellWindow::Create(this, params));
- // Interpretation of the bounds passed to NativeShellWindow::Create varies
- // between the different implementations, SetBounds behaves more consistent
- // so call that one here too. A fix for http://crbug.com/130184 should make
- // this no longer needed.
- if (params.bounds.x() >= 0 && params.bounds.y() >= 0) {
- native_window_->SetBounds(params.bounds);
- }
if (!params.window_key.empty()) {
window_key_ = params.window_key;

Powered by Google App Engine
This is Rietveld 408576698