Re-enable native UI for {frame:'chrome'} in app windows.

Re-enable native UI for {frame:'chrome'} in app windows.

The HTML titlebar is still available as {frame:'experimental-html'} when the --enable-experimental-extensions-apis command line switch is present.

R=mihaip@chromium.org
BUG=149689
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157216

[jeremya, 2012-09-14 20:13:05]

Cc'ing some people who might be interested.

[Mihai Parparita -not on Chrome, 2012-09-14 20:25:39]

LGTM

[commit-bot: I haz the power, 2012-09-14 20:27:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10917274/1

[Mihai Parparita -not on Chrome, 2012-09-14 21:09:11]

(unchecked the cq bit)

After thinking about this more, can we make the "experimenta-html" value only
work if the experimental command line flag is passed in? That would fit the
"experimental" name better.

To make that easier, it would be better if the decision to use/inject the HTML
titlebar lived in app_window_api.cc only, instead of also being spread into the
custom_bindings.js (e.g. if the result of the function included both the view ID
and the bool for whether to inject)

[jeremya, 2012-09-14 23:54:29]

I've moved things around so that the logic for deciding on titlebar-related
things is all in app_window_api.cc (good refactor anyway). However, I'm not sure
about putting it behind a flag -- I'm worried there are apps that depend on the
HTML titlebars already and I'd rather not find out about them post-branch.
Leaving it in without the flag means they can unbreak themselves in app code,
rather than requiring us to merge a change.

What harm is done by leaving it in?

[commit-bot: I haz the power, 2012-09-15 01:47:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10917274/5003

[commit-bot: I haz the power, 2012-09-15 01:47:04]

Presubmit check for 10917274-5003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/cocoa

[jeremya, 2012-09-15 01:52:22]

rsesek- could you take a look at the ui/cocoa parts?

Thanks!

[Robert Sesek, 2012-09-17 18:50:45]

http://codereview.chromium.org/10917274/diff/5003/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right):

http://codereview.chromium.org/10917274/diff/5003/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:180: if (has_frame_)
Multi-line bodies need {} braces.

http://codereview.chromium.org/10917274/diff/5003/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:182:
initWithContentRect:cocoa_bounds
nit: continuations need to be indented 4 spaces from the previous line, and on
188.

[jeremya, 2012-09-17 20:05:18]

Done.

[Robert Sesek, 2012-09-17 20:05:40]

lgtm

[commit-bot: I haz the power, 2012-09-17 20:14:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10917274/14001

[commit-bot: I haz the power, 2012-09-17 20:46:50]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-17 20:50:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10917274/14001

[commit-bot: I haz the power, 2012-09-17 22:16:58]

Change committed as 157216