Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2686)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 10917274: Re-enable native UI for {frame:'chrome'} in app windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index 04283fec5a0ed4059a0a36f007f8decec9d2bf11..f42829ac0b9915494de628350410379a7c8d5172 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -12,11 +12,10 @@ var GetView = appWindowNatives.GetView;
chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
- apiFunctions.setCustomCallback('create', function(name, request, viewId) {
+ apiFunctions.setCustomCallback('create', function(name, request, result) {
var view = null;
- if (viewId) {
- var shouldShowFrame = !request.args[1] || request.args[1].frame != 'none';
- view = GetView(viewId, !!shouldShowFrame);
+ if (result.viewId) {
+ view = GetView(result.viewId, result.injectTitlebar);
}
if (request.callback) {
request.callback(view.chrome.app.window.current());
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698