Chromium side of "consolidate two-phase connection to avoid race conditions".

Chromium side of "consolidate two-phase connection to avoid race conditions".

The full landing sequence for this needs to be determined - this is the 
"final state" on the Chromium side which would need to land after some WK
changes. See https://bugs.webkit.org/show_bug.cgi?id=90411

R=dgrogan@chromium.org
BUG=WK90411


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155937

[jsbell, 2012-09-05 22:33:12]

FYI - don't look too closely at this yet, it's still a WIP.

[jsbell, 2012-09-05 22:35:09]

https://chromiumcodereview.appspot.com/10917099/diff/1/content/browser/in_pro...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

https://chromiumcodereview.appspot.com/10917099/diff/1/content/browser/in_pro...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:243: new
IndexedDBDatabaseCallbacks(this, params.thread_id,
So... how about those awesome class names?

[jsbell, 2012-09-06 18:12:55]

Landing sequence is:

(1) Update Chromium to handle old/new WK API (this):
https://chromiumcodereview.appspot.com/10917099
(2) Land WK change: https://bugs.webkit.org/show_bug.cgi?id=90411
(3) Remove back-compat shims from Chromium
(4) Remove back-compat shims from WebKit/chromium/public

[dgrogan, 2012-09-07 00:42:49]

http://codereview.chromium.org/10917099/diff/1011/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/10917099/diff/1011/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:262:
Context()->GetIDBFactory()->open(
WebIDBFactory doesn't have a function with this signature yet.  I think you'll
have to land a webkit api patch before committing this chromium change.

[jsbell, 2012-09-07 15:48:01]

On 2012/09/07 00:42:49, dgrogan wrote:
>
http://codereview.chromium.org/10917099/diff/1011/content/browser/in_process_...
> File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):
> 
>
http://codereview.chromium.org/10917099/diff/1011/content/browser/in_process_...
> content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:262:
> Context()->GetIDBFactory()->open(
> WebIDBFactory doesn't have a function with this signature yet.  I think you'll
> have to land a webkit api patch before committing this chromium change.

Erp, yeah. I have that patch in a local branch, forgot to upload it anywhere. :P

I'll also try and pull over as much of the new WK api as possible, to ease the
burden on the reviewers.

[dgrogan, 2012-09-07 19:25:19]

lgtm

[commit-bot: I haz the power, 2012-09-10 17:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/10917099/1011

[commit-bot: I haz the power, 2012-09-10 17:35:34]

Presubmit check for 10917099-1011 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit/support

Presubmit checks took 1.3s to calculate.

[jsbell, 2012-09-10 22:53:09]

tkent@ - OWNERS review of webkit/support change?

[tkent, 2012-09-11 01:23:07]

LGTM for webkit/support/

[commit-bot: I haz the power, 2012-09-11 01:26:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/10917099/1011

[commit-bot: I haz the power, 2012-09-11 03:34:37]

Change committed as 155937