Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: content/common/indexed_db/proxy_webidbfactory_impl.cc

Issue 10917099: Chromium side of "consolidate two-phase connection to avoid race conditions". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Backwards compatible with current WK API Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/indexed_db/proxy_webidbfactory_impl.cc
diff --git a/content/common/indexed_db/proxy_webidbfactory_impl.cc b/content/common/indexed_db/proxy_webidbfactory_impl.cc
index d4bd56917e75c255aee35eaff511c68213866e0b..3e401d6c65eda078b624a10e82cda3055805ea2c 100644
--- a/content/common/indexed_db/proxy_webidbfactory_impl.cc
+++ b/content/common/indexed_db/proxy_webidbfactory_impl.cc
@@ -13,6 +13,7 @@ using WebKit::WebDOMStringList;
using WebKit::WebFrame;
using WebKit::WebIDBCallbacks;
using WebKit::WebIDBDatabase;
+using WebKit::WebIDBDatabaseCallbacks;
using WebKit::WebSecurityOrigin;
using WebKit::WebString;
@@ -33,6 +34,7 @@ void RendererWebIDBFactoryImpl::getDatabaseNames(
callbacks, origin.databaseIdentifier(), web_frame);
}
+// TODO(jsbell): Remove this overload when WK90411 rolls.
void RendererWebIDBFactoryImpl::open(
const WebString& name,
long long version,
@@ -48,6 +50,23 @@ void RendererWebIDBFactoryImpl::open(
name, version, callbacks, origin.databaseIdentifier(), web_frame);
}
+void RendererWebIDBFactoryImpl::open(
+ const WebString& name,
+ long long version,
+ WebIDBCallbacks* callbacks,
+ WebIDBDatabaseCallbacks* database_callbacks,
+ const WebSecurityOrigin& origin,
+ WebFrame* web_frame,
+ const WebString& data_dir) {
+ // Don't send the data_dir. We know what we want on the Browser side of
+ // things.
+ IndexedDBDispatcher* dispatcher =
+ IndexedDBDispatcher::ThreadSpecificInstance();
+ dispatcher->RequestIDBFactoryOpen(
+ name, version, callbacks, database_callbacks, origin.databaseIdentifier(),
+ web_frame);
+}
+
void RendererWebIDBFactoryImpl::deleteDatabase(
const WebString& name,
WebIDBCallbacks* callbacks,

Powered by Google App Engine
This is Rietveld 408576698