Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment

Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment (Closed)

Created:
8 years, 3 months ago by yosin_UTC9

Modified:
8 years, 3 months ago

Reviewers:
tfarina, sky

CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add bookmark entry point histogram for bookmark prompt experiment - How star icon activate ... mouse click, gesture, keyboard, accelerator - Counter for (really) bookmark added. UMA("Start") = number of star icon activated. The document of bookmark prompt experiment: https://docs.google.com/a/google.com/document/d/1N27VfFla4jfdjolxI50zns8HydnWKM7A6zBgpWUY9rM/view BUG=146233 R=sky@chromium.org TEST=No user visible changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156247

Patch Set 2 : Fix build break #

Total comments: 1

Patch Set 4 : Patch 3 - Add UMA counter in AddIfNotBookmarked #

Patch Set 5 : Update chrome/tools/chromeactions.txt for BookmarkAdded #

Total comments: 1

Patch Set 6 : Remove ENTRY_POINT_NONE #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	chrome/browser/bookmarks/bookmark_utils.h	View	1 2 3 4 5	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4 5	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/star_view.cc	View	1 2	3 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/tools/chromeactions.txt	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/10917062/diff/1/chrome/browser/bookmarks/bookmark_utils.h File chrome/browser/bookmarks/bookmark_utils.h (right): http://codereview.chromium.org/10917062/diff/1/chrome/browser/bookmarks/bookmark_utils.h#newcode236 chrome/browser/bookmarks/bookmark_utils.h:236: BOOKMARK_ENTRY_POINT_NONE, nit: indent two spaces only

8 years, 3 months ago (2012-09-03 11:33:03 UTC) #2

yosin_UTC9

Could you review this patch? Failure on win_rel doesn't relate to this patch. Thanks in ...

8 years, 3 months ago (2012-09-04 07:44:56 UTC) #3

sky

It seems like the experiment wants to measure bookmark creation. Doing any of these gestures ...

8 years, 3 months ago (2012-09-04 15:57:49 UTC) #4

sky

What is the decision regarding: > It seems like the experiment wants to measure bookmark ...

8 years, 3 months ago (2012-09-10 15:56:55 UTC) #6

yosin_UTC9

> > It seems like the experiment wants to measure bookmark creation. Doing any of ...

8 years, 3 months ago (2012-09-11 01:50:55 UTC) #7

sky

http://codereview.chromium.org/10917062/diff/5004/chrome/browser/bookmarks/bookmark_utils.h File chrome/browser/bookmarks/bookmark_utils.h (right): http://codereview.chromium.org/10917062/diff/5004/chrome/browser/bookmarks/bookmark_utils.h#newcode236 chrome/browser/bookmarks/bookmark_utils.h:236: ENTRY_POINT_NONE, This is never used, can it be removed?

8 years, 3 months ago (2012-09-11 15:49:51 UTC) #8

yosin_UTC9

Could you review this patch? Thanks in advance. = Changes since the last review = ...

8 years, 3 months ago (2012-09-12 03:58:43 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/10917062/2007

8 years, 3 months ago (2012-09-12 05:00:06 UTC) #11

Change committed as 156247

Expand Messages | Collapse Messages