Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/bookmarks/bookmark_utils.h

Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_ 6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 // Removes all bookmarks for the given |url|. 224 // Removes all bookmarks for the given |url|.
225 void RemoveAllBookmarks(BookmarkModel* model, const GURL& url); 225 void RemoveAllBookmarks(BookmarkModel* model, const GURL& url);
226 226
227 // Number of bookmarks we'll open before prompting the user to see if they 227 // Number of bookmarks we'll open before prompting the user to see if they
228 // really want to open all. 228 // really want to open all.
229 // 229 //
230 // NOTE: treat this as a const. It is not const as various tests change the 230 // NOTE: treat this as a const. It is not const as various tests change the
231 // value. 231 // value.
232 extern int num_urls_before_prompting; 232 extern int num_urls_before_prompting;
233 233
234 // This enum is used for the Bookmarks.EntryPoint histogram.
235 enum BoomarkEntryPoint {
236 BOOKMARK_ENTRY_POINT_NONE,
tfarina 2012/09/03 11:33:03 nit: indent two spaces only
237 BOOKMARK_ENTRY_POINT_ACCELERATOR = 0,
238 BOOKMARK_ENTRY_POINT_STAR_GESTURE,
239 BOOKMARK_ENTRY_POINT_STAR_KEY,
240 BOOKMARK_ENTRY_POINT_STAR_MOUSE,
241 BOOKMARK_ENTRY_POINT_STAR_SHORTCUT,
242
243 BOOKMARK_ENTRY_POINT_LIMIT // Keep this last.
244 };
245
234 // This enum is used for the Bookmarks.LaunchLocation histogram. 246 // This enum is used for the Bookmarks.LaunchLocation histogram.
235 enum BookmarkLaunchLocation { 247 enum BookmarkLaunchLocation {
236 LAUNCH_NONE, 248 LAUNCH_NONE,
237 LAUNCH_ATTACHED_BAR = 0, 249 LAUNCH_ATTACHED_BAR = 0,
238 LAUNCH_DETACHED_BAR, 250 LAUNCH_DETACHED_BAR,
239 // These two are kind of sub-categories of the bookmark bar. Generally 251 // These two are kind of sub-categories of the bookmark bar. Generally
240 // a launch from a context menu or subfolder could be classified in one of 252 // a launch from a context menu or subfolder could be classified in one of
241 // the other two bar buckets, but doing so is difficult because the menus 253 // the other two bar buckets, but doing so is difficult because the menus
242 // don't know of their greater place in Chrome. 254 // don't know of their greater place in Chrome.
243 LAUNCH_BAR_SUBFOLDER, 255 LAUNCH_BAR_SUBFOLDER,
(...skipping 13 matching lines...) Expand all
257 void RecordBookmarkLaunch(BookmarkLaunchLocation location); 269 void RecordBookmarkLaunch(BookmarkLaunchLocation location);
258 270
259 #if defined(OS_WIN) || defined(OS_CHROMEOS) || defined(USE_AURA) 271 #if defined(OS_WIN) || defined(OS_CHROMEOS) || defined(USE_AURA)
260 void DisableBookmarkBarViewAnimationsForTesting(bool disabled); 272 void DisableBookmarkBarViewAnimationsForTesting(bool disabled);
261 bool IsBookmarkBarViewAnimationsDisabled(); 273 bool IsBookmarkBarViewAnimationsDisabled();
262 #endif 274 #endif
263 275
264 } // namespace bookmark_utils 276 } // namespace bookmark_utils
265 277
266 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_ 278 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698