Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10916316: Add support for non-all-lower-case meta tags. (Closed)

Created:
8 years, 3 months ago by bcwhite
Modified:
8 years, 2 months ago
Reviewers:
MAD, brett
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add support for non-all-lower-case meta tags. First & second CLs required WebKit change that make the "equalsIgnoringCase" function visible to these files. This change was rejected. Third CL is self-contained. BUG=145689 TEST=see URL #3 in bug (fix for URL #1 in different CL) Obsolete by https://codereview.chromium.org/11052002/

Patch Set 1 #

Patch Set 2 : Chromium Bug #145689 #

Patch Set 3 : Alternate method of handling case-insensitivity that doesn't require changes to WebKit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M chrome/renderer/translate_helper.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/translate_helper_browsertest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M webkit/glue/dom_operations.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/dom_operations.cc View 1 2 4 chunks +7 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
bcwhite
8 years, 3 months ago (2012-09-14 14:35:07 UTC) #1
MAD
Cool... Thanks! LGTM
8 years, 3 months ago (2012-09-14 15:01:59 UTC) #2
bcwhite1
FYI: It's dependent on a WebKit change to make "equalsIgnoringCase" available. Working on getting that ...
8 years, 3 months ago (2012-09-14 16:32:28 UTC) #3
bcwhite
New patch submitted that doesn't require any changes to WebKit.
8 years, 2 months ago (2012-09-27 17:59:18 UTC) #4
MAD
Still LGTM, with one small question/request... Thanks! BYE MAD... http://codereview.chromium.org/10916316/diff/7001/webkit/glue/dom_operations.cc File webkit/glue/dom_operations.cc (right): http://codereview.chromium.org/10916316/diff/7001/webkit/glue/dom_operations.cc#newcode12 webkit/glue/dom_operations.cc:12: ...
8 years, 2 months ago (2012-09-27 20:19:44 UTC) #5
bcwhite
http://codereview.chromium.org/10916316/diff/7001/webkit/glue/dom_operations.cc#newcode12 > webkit/glue/dom_operations.cc:12: #include "base/utf_string_conversions.h" > Did you try to also remove it from chrome/renderer/translate_helper.cc? ...
8 years, 2 months ago (2012-09-27 20:43:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/10916316/7001
8 years, 2 months ago (2012-09-27 21:16:05 UTC) #7
commit-bot: I haz the power
Presubmit check for 10916316-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-27 21:16:09 UTC) #8
bcwhite
8 years, 2 months ago (2012-09-28 12:33:26 UTC) #9
Brett, would you mind taking a look at this patch?  It covers files in two
directories in which you're an owner.  Thanks.

-- Brian

Powered by Google App Engine
This is Rietveld 408576698