Get the document language directly from WebKit

Get the document language directly from WebKit rather than trying to figure
it out ourselves.  Since WebKit is already case-insensitive, this fixes
test-case #3.  Test-Case #1 requires WebKit support for extracting the
language from the HTTP headers (https://bugs.webkit.org/show_bug.cgi?id=97929).

Note that this patch will fail completely until a WebKit patch to export
this information is accepted (https://bugs.webkit.org/show_bug.cgi?id=98066).

BUG=145689
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162212

[bcwhite, 2012-10-02 19:44:49]

CL to export this value has now been accepted into base WebKit.  CL to support
language in HTTP header is still pending.

[MAD, 2012-10-02 20:15:26]

LGTM with a small comment nit...

Thanks!

BYE
MAD

https://codereview.chromium.org/11052002/diff/1/chrome/renderer/translate_hel...
File chrome/renderer/translate_helper.cc (right):

https://codereview.chromium.org/11052002/diff/1/chrome/renderer/translate_hel...
chrome/renderer/translate_helper.cc:65: // determine it based on the text
content using the CLD.
determine it???

[bcwhite, 2012-10-03 14:52:21]

I need reviews from two OWNERS on this.  Thanks!

[jschuh, 2012-10-03 15:09:43]

On 2012/10/03 14:52:21, bcwhite wrote:
> I need reviews from two OWNERS on this.  Thanks!

I don't see anything involving the Windows sandbox, so I don't know why I'm
listed as a reviewer.

[bcwhite1, 2012-10-03 15:16:40]

On 2012/10/03 14:52:21, bcwhite wrote:

>  I need reviews from two OWNERS on this.  Thanks!
>>
>
> I don't see anything involving the Windows sandbox, so I don't know why I'm
> listed as a reviewer.
>

The OWNERS file for "content/common" is very sparse with nobody listed for
non-sandbox elements.

  Brian  (now in Montreal, Canada)
  bcwhite@google.com
-----------------------------------------------------------------------------------------
*Treat someone as they are and they will remain that way.
Treat someone as they can be and they will become that way.

*

[jschuh, 2012-10-03 15:49:57]

On 2012/10/03 15:16:40, bcwhite_google.com wrote:
> On 2012/10/03 14:52:21, bcwhite wrote:
> 
> >  I need reviews from two OWNERS on this.  Thanks!
> >>
> >
> > I don't see anything involving the Windows sandbox, so I don't know why I'm
> > listed as a reviewer.
> >
> 
> The OWNERS file for "content/common" is very sparse with nobody listed for
> non-sandbox elements.

Sorry if I came across as overly curt, but as the file states no one in
content/common/OWNERS can review your change. So, you should select a reviewer
from the OWNERS file in a parent directory.

[bcwhite, 2012-10-03 16:19:02]

-jschuh
+avi

Please provide OWNERS review for content/common file.  Thanks.

[bcwhite, 2012-10-12 14:53:57]

+jhawkins

Would an OWNER please review this?  It's been over a week.  Thanks.

[James Hawkins, 2012-10-12 22:43:13]

lgtm

[commit-bot: I haz the power, 2012-10-15 14:34:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/11052002/13001

[commit-bot: I haz the power, 2012-10-16 14:00:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/11052002/13001

[commit-bot: I haz the power, 2012-10-16 19:35:07]

Change committed as 162212

[Lei Zhang, 2012-10-16 20:42:08]

There's something weird with your client. In the raw patch:

Index: chrome/renderer/translate_helper.cc
diff --git a/chrome/renderer/translate_helper.cc
b/chrome/renderer/translate_helper.cc
old mode 100644
new mode 100755

[bcwhite, 2012-10-16 20:47:03]

> There's something weird with your client. In the raw patch:

Yeah.  The presubmit noted the error but didn't abort the automated commit.  A
fix CL is pending:
https://codereview.chromium.org/11195008/

[bcwhite, 2012-10-17 17:48:40]

Looks like someone else submitted first.