Reland DownloadManager::GetAllDownloads actually does now

Reland Make DownloadManager::GetAllDownloads return all downloads regardless of state, persistence, temporariness, or save page.

Callers such as download_status_updater_mac now need to explicitly check whether filenames are empty.

Also change some callers from SearchDownloads() over to GetAllDownloads().

This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/

I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something.


Reviewers breakdown:
Done:
rdsmith: *
jam: chrome/browser/automation
michaeln: chrome/browser/browsing_data
jcivelli: content/public/test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155351
BUG=147359
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155829

[benjhayden, 2012-09-04 21:08:36]

PTAL

[Randy Smith (Not in Mondays), 2012-09-05 17:45:43]

Fix the issue description so that it includes the missing right angle brackets. 
Beyond that, LGTM (the below comments are optional).

http://codereview.chromium.org/10913015/diff/4002/chrome/browser/download/dow...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/10913015/diff/4002/chrome/browser/download/dow...
chrome/browser/download/download_browsertest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
Are there any uses of GetTemporaryDownloads() in this file that can (should?) be
converted?

http://codereview.chromium.org/10913015/diff/4002/content/public/test/downloa...
File content/public/test/download_test_observer.cc (right):

http://codereview.chromium.org/10913015/diff/4002/content/public/test/downloa...
content/public/test/download_test_observer.cc:297: continue;
I think you could let this include temporary downloads if you wanted.

[benjhayden, 2012-09-05 20:56:57]

http://codereview.chromium.org/10913015/diff/4002/chrome/browser/download/dow...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/10913015/diff/4002/chrome/browser/download/dow...
chrome/browser/download/download_browsertest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2012/09/05 17:45:43, rdsmith wrote:
> Are there any uses of GetTemporaryDownloads() in this file that can (should?)
be
> converted?

ctrl+f says there aren't any GetTemporaryDownloads() calls in this file.

http://codereview.chromium.org/10913015/diff/4002/content/public/test/downloa...
File content/public/test/download_test_observer.cc (right):

http://codereview.chromium.org/10913015/diff/4002/content/public/test/downloa...
content/public/test/download_test_observer.cc:297: continue;
On 2012/09/05 17:45:43, rdsmith wrote:
> I think you could let this include temporary downloads if you wanted.

Done.

[commit-bot: I haz the power, 2012-09-06 15:49:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10913015/9022

[commit-bot: I haz the power, 2012-09-06 15:49:12]

Presubmit check for 10913015-9022 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/automation
    chrome/browser/browsing_data
    content/public/test

Presubmit checks took 1.5s to calculate.

[benjhayden, 2012-09-06 16:25:34]

John, Michael, Jay: PTAL for OWNERShip at your respective directories
(enumerated in CL description)

[Jay Civelli, 2012-09-06 17:04:12]

LGTM for content/public/test/

[michaeln, 2012-09-06 20:03:40]

lgtm (chrome/browser/browser_data)

[jam, 2012-09-06 21:00:41]

lgtm

[commit-bot: I haz the power, 2012-09-06 21:02:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10913015/9022

[commit-bot: I haz the power, 2012-09-07 07:06:59]

Change committed as 155351

[benjhayden, 2012-09-08 17:35:45]

Randy, PTAL for reland.

Only change is an early-return in download_status_updater_mac.mm.

[Avi (use Gerrit), 2012-09-08 17:39:07]

Mac updater code LGTM

[Randy Smith (Not in Mondays), 2012-09-08 17:39:09]

I'd like Avi to review that change--adding him to the reviewer list.

Confirming: You skimmed through the consumers and decided this was the right way
to go?

[Randy Smith (Not in Mondays), 2012-09-08 17:44:17]

To be clear: LGTM, presuming you skimmed through the consumers.

[commit-bot: I haz the power, 2012-09-10 19:20:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10913015/16001

[commit-bot: I haz the power, 2012-09-10 21:18:06]

Change committed as 155829