chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 10913015: Reland DownloadManager::GetAllDownloads actually does now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 10913015: Reland DownloadManager::GetAllDownloads actually does now (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 43b6b43c4c0a768ec146c099412e1dffffc7f09e..83b0de8a4ece2f99172273c6e6bdc04897c47e7a 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -471,11 +471,11 @@ void RunDownloadQuery(

if (item)

all_items.push_back(item);

} else {

- manager->GetAllDownloads(FilePath(FILE_PATH_LITERAL("")), &all_items);

+ manager->GetAllDownloads(&all_items);

if (incognito_manager)

- incognito_manager->GetAllDownloads(

- FilePath(FILE_PATH_LITERAL("")), &all_items);

+ incognito_manager->GetAllDownloads(&all_items);

}

+ query_out.AddFilter(base::Bind(&IsNotTemporaryDownloadFilter));

query_out.Search(all_items.begin(), all_items.end(), results);

}