Issue 10912168: events: Add some test.

Issue 10912168: events: Add some test. (Closed)

Created:
8 years, 3 months ago by sadrul

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

events: Add some test. Add a test to verify that the event-handlers are called in the right order. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155663 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155727

Patch Set 7 : win-component #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -40 lines)			Patch
M	ui/base/events/event.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/events/event_constants.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/events/event_dispatcher.h	View	1 2 3 4 5 6	3 chunks	+10 lines, -28 lines	0 comments	Download
A	ui/base/events/event_dispatcher.cc	View	1 2 3 4 5 6	1 chunk	+47 lines, -0 lines	0 comments	Download
A	ui/base/events/event_dispatcher_unittest.cc	View	1 2 3 4 5 6	1 chunk	+185 lines, -0 lines	0 comments	Download
M	ui/base/events/event_handler.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/events/event_target.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/ui.gyp	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/10912168/diff/8002/ui/base/events/event_dispatcher_unittest.cc File ui/base/events/event_dispatcher_unittest.cc (right): http://codereview.chromium.org/10912168/diff/8002/ui/base/events/event_dispatcher_unittest.cc#newcode143 ui/base/events/event_dispatcher_unittest.cc:143: // receive these events. Is this because you ...

8 years, 3 months ago (2012-09-09 19:43:15 UTC) #2

sadrul

8 years, 3 months ago (2012-09-10 05:04:01 UTC) #3

http://codereview.chromium.org/10912168/diff/8002/ui/base/events/event_dispat...
File ui/base/events/event_dispatcher_unittest.cc (right):

http://codereview.chromium.org/10912168/diff/8002/ui/base/events/event_dispat...
ui/base/events/event_dispatcher_unittest.cc:143: // receive these events.
On 2012/09/09 19:43:16, Ben Goodger (Google) wrote:
> Is this because you haven't made this behavioral change yet? If so, can you
file
> a bug and cite it here? This shouldn't be perceived as a permanent behavior.

Indeed. I have filed a bug and referenced it from here. I am not entirely sure
if that change should happen for M23 though. I will put up a patch.

Expand Messages | Collapse Messages