Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

Issue 10911084: Implement Invalidator::Acknowledge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restart test + more cleanup Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc
diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc
index cee8305e0cfb75a753fec60d39575e490084fb5a..c3dec490166ea9929b51eef917bcf7bb2a9cd429 100644
--- a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc
+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc
@@ -131,6 +131,7 @@ void PushMessagingInvalidationHandler::OnIncomingInvalidation(
&subchannel)) {
delegate_->OnMessage(extension_id, subchannel, it->second.payload);
akalin 2012/10/19 13:27:16 Question: Is this synchronous? i.e., can we ack i
dcheng 2012/10/19 19:38:11 Doing this properly is somewhat harder, as this in
}
+ service_->AcknowledgeInvalidation(it->first, it->second.ack_handle);
}
}

Powered by Google App Engine
This is Rietveld 408576698